Open
Conversation
📝 WalkthroughWalkthroughAdded comprehensive documentation for installing Google Services as system-privileged applications via ADB, including device verification, APK downloads, permission configuration, and MuMu Player 12-specific instructions for writable system partitions. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (5)
README.md (5)
96-96: Improve Chinese grammar for clarity.The phrase "Shift+右键的，在此打开Powershell" is grammatically awkward. Consider revising for better readability.
✏️ Suggested revision
-- 模拟器目录通常有预装Adb.exe，可直接用命令行调用。比如Shift+右键的，在此打开Powershell。 +- 模拟器目录通常有预装 ADB.exe，可直接用命令行调用。比如按住 Shift 后右键，选择"在此处打开 PowerShell 窗口"。🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` at line 96, The sentence containing "Shift+右键的，在此打开Powershell" is grammatically awkward; update the README sentence to use correct Chinese phrasing such as "按住 Shift 并右键，在此处打开 PowerShell" or "在此处打开 PowerShell（按住 Shift 并右键）" to improve clarity, replacing the original phrase in the README.md.
93-100: Consider adding backup warning in prerequisites.Modifying the
/systempartition carries risks. Consider adding a warning to backup the device/emulator before proceeding, especially for users unfamiliar with ADB operations.
⚠️ Suggested additionAdd after line 99:
- **重要**：建议操作前备份设备或模拟器实例，避免意外损坏系统🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` around lines 93 - 100, Add a clear backup warning in the "前提条件" README section: after the list item mentioning the `/system` partition, insert a bullet like "重要：建议操作前备份设备或模拟器实例，避免意外损坏系统" to advise users to back up their device/emulator before performing ADB or `/system` modifications (reference the `/system` partition and ADB prerequisites in this section).
132-134: Use clearer path placeholders for Windows users.Since the instructions specifically mention PowerShell (line 103), the placeholder paths "路径/gsf.apk" should use Windows-style examples to avoid confusion. Unix-style forward slashes may work but can confuse beginners.
📁 Suggested path format improvement
-# 推送 APK（替换为你本地实际文件路径） -adb push "路径/gsf.apk" /system/priv-app/GoogleServicesFramework/GoogleServicesFramework.apk -adb push "路径/gms.apk" /system/priv-app/GooglePlayServices/GooglePlayServices.apk -adb push "路径/vending.apk" /system/priv-app/Phonesky/Phonesky.apk +# 推送 APK（替换为你本地实际文件路径，例如 C:\Downloads\gsf.apk） +adb push "C:\Downloads\gsf.apk" /system/priv-app/GoogleServicesFramework/GoogleServicesFramework.apk +adb push "C:\Downloads\gms.apk" /system/priv-app/GooglePlayServices/GooglePlayServices.apk +adb push "C:\Downloads\vending.apk" /system/priv-app/Phonesky/Phonesky.apk🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` around lines 132 - 134, Replace the Unix-style placeholder paths in the adb push examples with Windows-style placeholders to match the PowerShell context: update the three lines that reference "路径/gsf.apk", "路径/gms.apk", and "路径/vending.apk" to use e.g. "C:\path\to\gsf.apk", "C:\path\to\gms.apk", and "C:\path\to\vending.apk" (keeping the destination paths unchanged and preserving the quoted strings).
124-124: Add guidance foradb rootfailures.Not all rooted devices support the
adb rootcommand (it depends on the ADB daemon build). Consider adding a note about alternative approaches if this command fails.🔧 Suggested addition
Add after line 124:
# 如果 adb root 失败，可尝试： # adb shell # su # 然后在 shell 中执行后续命令（去掉 adb shell 前缀）🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` at line 124, The README currently lists the single command "adb root" which can fail on some devices; add a brief note immediately after the "adb root" entry explaining fallback steps for devices where that command doesn't work: open an interactive shell with "adb shell", run "su" to gain root, then run the subsequent commands inside that shell (i.e., remove the "adb shell" prefix from those commands); include the suggested Chinese snippet as an alternative example to aid users.
117-120: Clarify APK selection criteria.The explanation "minAPI 不超过你的 SDK 版本（在Min~Target之间）" may be unclear to users unfamiliar with Android API levels. Consider expanding this to explain that the device's SDK version should fall between the APK's minimum and target API levels.
📝 Suggested clarification
-前往 [APKMirror](https://www.apkmirror.com) 按照上述信息下载三个 APK，选择规则： -- `minAPI` 不超过你的 SDK 版本 （在Min~Target之间） +前往 [APKMirror](https://www.apkmirror.com) 按照上述信息下载三个 APK，选择规则： +- 选择 `minAPI`（最低API）≤ 你的SDK版本 ≤ `targetAPI`（目标API）的版本 - ABI 架构与 `ro.product.cpu.abi` 一致（或选 `nodpi` 通用版）🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` around lines 117 - 120, The sentence "minAPI 不超过你的 SDK 版本（在Min~Target之间）" is ambiguous; update the README bullet explaining APK selection to explicitly state that the device's Android SDK version must be greater than or equal to the APK's minSdkVersion and less than or equal to the APK's targetSdkVersion (i.e., device SDK should fall between the APK's Min and Target API levels), and keep the existing ABI guidance referencing `ro.product.cpu.abi` (or using `nodpi` for universal builds) so readers can match CPU architecture to the APK.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 148: The README contains a PowerShell-incompatible command "adb shell pm
list packages | grep google"; update it to a PowerShell-friendly alternative or
note the requirement: either run grep inside the Android shell by changing to
adb shell "pm list packages | grep google", or provide a native PowerShell
equivalent such as piping to Select-String (adb shell pm list packages |
Select-String google) or using findstr (adb shell pm list packages | findstr
google), and add a short note that grep requires Git Bash/WSL if the user
prefers the original form.
---
Nitpick comments:
In `@README.md`:
- Line 96: The sentence containing "Shift+右键的，在此打开Powershell" is grammatically
awkward; update the README sentence to use correct Chinese phrasing such as "按住
Shift 并右键，在此处打开 PowerShell" or "在此处打开 PowerShell（按住 Shift 并右键）" to improve
clarity, replacing the original phrase in the README.md.
- Around line 93-100: Add a clear backup warning in the "前提条件" README section:
after the list item mentioning the `/system` partition, insert a bullet like
"重要：建议操作前备份设备或模拟器实例，避免意外损坏系统" to advise users to back up their device/emulator
before performing ADB or `/system` modifications (reference the `/system`
partition and ADB prerequisites in this section).
- Around line 132-134: Replace the Unix-style placeholder paths in the adb push
examples with Windows-style placeholders to match the PowerShell context: update
the three lines that reference "路径/gsf.apk", "路径/gms.apk", and "路径/vending.apk"
to use e.g. "C:\path\to\gsf.apk", "C:\path\to\gms.apk", and
"C:\path\to\vending.apk" (keeping the destination paths unchanged and preserving
the quoted strings).
- Line 124: The README currently lists the single command "adb root" which can
fail on some devices; add a brief note immediately after the "adb root" entry
explaining fallback steps for devices where that command doesn't work: open an
interactive shell with "adb shell", run "su" to gain root, then run the
subsequent commands inside that shell (i.e., remove the "adb shell" prefix from
those commands); include the suggested Chinese snippet as an alternative example
to aid users.
- Around line 117-120: The sentence "minAPI 不超过你的 SDK 版本（在Min~Target之间）" is
ambiguous; update the README bullet explaining APK selection to explicitly state
that the device's Android SDK version must be greater than or equal to the APK's
minSdkVersion and less than or equal to the APK's targetSdkVersion (i.e., device
SDK should fall between the APK's Min and Target API levels), and keep the
existing ABI guidance referencing `ro.product.cpu.abi` (or using `nodpi` for
universal builds) so readers can match CPU architecture to the APK.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| ### 第四步：验证安装结果 | ||
|
|
||
| ```powershell | ||
| adb shell pm list packages | grep google |
There was a problem hiding this comment.
PowerShell incompatibility: grep not available natively on Windows.
The command uses grep which is not available in Windows PowerShell by default. Since this section explicitly targets PowerShell users (line 103), this command will fail unless users have Git Bash or WSL installed.
🔧 PowerShell-compatible fix
-adb shell pm list packages | grep google
+# PowerShell 用户使用 Select-String:
+adb shell pm list packages | Select-String google
+
+# 或使用 Windows 原生 findstr:
+adb shell pm list packages | findstr googleAlternatively, add a note that grep requires Git Bash/WSL, or use adb shell "pm list packages | grep google" to run grep inside the Android shell instead.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` at line 148, The README contains a PowerShell-incompatible command
"adb shell pm list packages | grep google"; update it to a PowerShell-friendly
alternative or note the requirement: either run grep inside the Android shell by
changing to adb shell "pm list packages | grep google", or provide a native
PowerShell equivalent such as piping to Select-String (adb shell pm list
packages | Select-String google) or using findstr (adb shell pm list packages |
findstr google), and add a short note that grep requires Git Bash/WSL if the
user prefers the original form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
原文很好地解释了装什么。我补充具体怎么安装，我觉得使用ADB方法比较泛用，并对Mumu遇到的问题给出针对解决方案。
此PR仅添加
4作为补充 ，对原有说明未做删改。Summary by CodeRabbit